arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill
Plugins Handler
URL: https://github.com/apache/drill/pull/1345#discussion_r198853478
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java
##########
@@ -248,6 +248,12 @@ private ExecConstants() {
*/
public static final String DEFAULT_TEMPORARY_WORKSPACE =
"drill.exec.default_temporary_workspace";
+ /**
+ * Storage plugins configs will be updated in the case, when
+ * {@link
org.apache.drill.common.config.CommonConstants#STORAGE_PLUGINS_UPDATER_FILE}
file is present
+ */
+ public static final String STORAGE_PLUGINS_UPDATE =
"drill.exec.storage_plugins.update.enabled";
Review comment:
1. drill.exec.storage_plugins.override.allowed and
ALLOW_OVERRIDE_STORAGE_PLUGINS?
2. Do we really need this config? I think if files exists, we add / update
storage plugins, if not, we don't. I would consider following the same
semantics as we have for drill-override.conf.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
