arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198860138
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandler.java ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.store; + +import org.apache.drill.common.logical.StoragePluginConfig; +import org.apache.drill.exec.planner.logical.StoragePlugins; +import org.apache.drill.exec.store.sys.PersistentStore; + + +/** + * Storage plugins handler is an additional service for updating storage plugins configs from the file + */ +public interface StoragePluginsHandler { + + /** + * Update incoming storage plugins configs from persistence store if present, otherwise bootstrap plugins configs. + * One of the params should be null, second shouldn't + * + * @param bootstrapPlugins bootstrap storage plugins, which are used in case of first Drill start up + * @param persistentStore the last storage plugins configs from persistence store + * @return all storage plugins, which should be loaded into persistence store + */ + StoragePlugins updatePlugins(StoragePlugins bootstrapPlugins, PersistentStore<StoragePluginConfig> persistentStore); Review comment: As I have mentioned above, I would consider treating storage-plugins.conf as tool to update and add plugins. With this perspective we can rename method to loadPlugins or something else. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
