paul-rogers commented on a change in pull request #1371: DRILL-6588: Make Sys
tables of nullable datatypes
URL: https://github.com/apache/drill/pull/1371#discussion_r201522572
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/RecordDataType.java
##########
@@ -49,15 +55,25 @@
public final RelDataType getRowType(RelDataTypeFactory factory) {
final List<SqlTypeName> types = getFieldSqlTypeNames();
final List<String> names = getFieldNames();
+ final List<Boolean> nullables = getFieldNullability();
final List<RelDataType> fields = Lists.newArrayList();
- for (final SqlTypeName typeName : types) {
+ Iterator<SqlTypeName> typesIter = types.listIterator();
+ Iterator<Boolean> nullabilityIter = nullables.listIterator();
Review comment:
We now four correlated lists. This is often difficult to reason about and
maintain.
Is it possible to have a single list of, say, `FieldDefn` objects, each of
which has a name, type, nullable and `RelDataType`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
