paul-rogers commented on a change in pull request #1371: DRILL-6588: Make Sys
tables of nullable datatypes
URL: https://github.com/apache/drill/pull/1371#discussion_r201533730
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/RecordDataType.java
##########
@@ -49,15 +55,25 @@
public final RelDataType getRowType(RelDataTypeFactory factory) {
final List<SqlTypeName> types = getFieldSqlTypeNames();
final List<String> names = getFieldNames();
+ final List<Boolean> nullables = getFieldNullability();
final List<RelDataType> fields = Lists.newArrayList();
- for (final SqlTypeName typeName : types) {
+ Iterator<SqlTypeName> typesIter = types.listIterator();
+ Iterator<Boolean> nullabilityIter = nullables.listIterator();
Review comment:
This is, in fact, the gist of the comment. While it is understandable to
want to leave he existing code as-is, adding more lists to the existing
parallel lists is not an improvement: it has caused a semi-wrong initial
implementation to become overly cumbersome.
If the implementation is local to this class or module, then leaving the
code cleaner after your change than when you found it is generally a good thing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
