paul-rogers commented on a change in pull request #1371: DRILL-6588: Make Sys 
tables of nullable datatypes
URL: https://github.com/apache/drill/pull/1371#discussion_r201909347
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/BitToUserConnectionIterator.java
 ##########
 @@ -99,14 +102,18 @@ public void remove() {
 
   public static class ConnectionInfo {
     public String user;
+    @Nonnull
 
 Review comment:
   Sorry, I was misled by the "javax" package and thought this was a Java 
thing. Good catch @arina-ielchiieva.
   
   Since it is not, go ahead and define your own. Today we assume all fields 
are nullable, and must keep that default. So, since the default is nullable, 
you only need the `@NonNullable` annotation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to