paul-rogers commented on a change in pull request #1371: DRILL-6588: Make Sys
tables of nullable datatypes
URL: https://github.com/apache/drill/pull/1371#discussion_r201523513
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/pojo/PojoDataType.java
##########
@@ -48,6 +49,11 @@ public PojoDataType(Class<?> pojoClass) {
Class<?> type = f.getType();
names.add(f.getName());
+ //Look up @Nullability for nullable property
+ Nullability nullability = f.getDeclaredAnnotation(Nullability.class);
+ nullables.add(nullability == null ? //Absence of annotation =>
(isNullable=true)
Review comment:
`f.isAnnotationPresent(Nullability.class)` returns a `boolean` result; may
simplify the code here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
