jnturton commented on code in PR #2655:
URL: https://github.com/apache/drill/pull/2655#discussion_r979818742


##########
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerConfig.java:
##########
@@ -52,12 +59,81 @@ public QueryContext getContext() {
     return context;
   }
 
+  private RuleSet attemptToGetRules(PlannerPhase phase, 
Collection<StoragePlugin> plugins) throws PluginException{

Review Comment:
   @vvysotskyi so do we keep auto disabling but drop retry here? We've seen 
JDBC plugins that point to an unresponsive remote DB fail with the first 
exception coming from rule collection (because, unlike most plugins, JDBC 
already tries to contact the remote DB for this operation). And of course 
before DRILL-8234, JDBC plugins not even involved in a query could cause it to 
fail during rule collection. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to