jnturton commented on code in PR #2655:
URL: https://github.com/apache/drill/pull/2655#discussion_r979833628
##########
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java:
##########
@@ -1094,6 +1095,35 @@ public static String bootDefaultFor(String name) {
new OptionDescription("Enables recursive files listing when querying the
`INFORMATION_SCHEMA.FILES` table or executing the SHOW FILES command. " +
"Default is false. (Drill 1.15+)"));
+ public static final String STORAGE_PLUGIN_ACCESS_ATTEMPTS =
"storage.plugin_access_attempts";
+ public static final PositiveLongValidator
STORAGE_PLUGIN_ACCESS_ATTEMPTS_VALIDATOR = new PositiveLongValidator(
+ STORAGE_PLUGIN_ACCESS_ATTEMPTS,
+ 10,
+ new OptionDescription(
+ "The maximum number of attempts that will be made to request metadata " +
+ "needed for query planning from a storage plugin."
+ )
+ );
+ public static final String STORAGE_PLUGIN_ATTEMPT_DELAY =
"storage.plugin_access_attempt_delay";
+ public static final NonNegativeLongValidator
STORAGE_PLUGIN_ATTEMPT_DELAY_VALIDATOR = new NonNegativeLongValidator(
+ STORAGE_PLUGIN_ATTEMPT_DELAY,
+ 5*60*1000,
+ new OptionDescription(
+ "The delay in milliseconds between repeated attempts to request metadata
" +
Review Comment:
@vvysotskyi I did implement this that way initially but if you look I ended
up making the two features - storage plugin retry and storage plugin auto
disable - independent of each other here. Users could choose to have retry and
no auto disable, or to have auto disable and no retry the way it is currently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
