vvysotskyi commented on code in PR #2655:
URL: https://github.com/apache/drill/pull/2655#discussion_r981716643


##########
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerConfig.java:
##########
@@ -52,12 +59,81 @@ public QueryContext getContext() {
     return context;
   }
 
+  private RuleSet attemptToGetRules(PlannerPhase phase, 
Collection<StoragePlugin> plugins) throws PluginException{

Review Comment:
   I meant to drop both retry and auto-disabling logic. I have checked JDBC 
plugin, and it has several places where the data source is created. One of them 
is `getOptimizerRules` which is used here, and another one is 
`registerSchemas`, which is called during validation, before this place. So if 
we have something broken, it should fail before calling this method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to