jnturton commented on code in PR #2655:
URL: https://github.com/apache/drill/pull/2655#discussion_r979823862
##########
exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java:
##########
@@ -34,12 +34,22 @@ public interface StoragePluginRegistry extends
Iterable<Map.Entry<String, Storag
@SuppressWarnings("serial")
public static class PluginException extends Exception {
+
+ public final StoragePlugin plugin;
Review Comment:
@vvysotskyi I added a reference to the plugin related to the exception so
that when an exception is thrown from PlannerPhase#getStorageRules the calling
code has a way to find _which_ plugin from the collection that it passed in was
the one that failed. It needs to know that if it is to go on to disable that
plugin. But there must be other ways of sharing that data with the caller if
you think using the exception object is not a good choice...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
