Hi all,
well I did have a more detailed look at the original (Gradle) version and the
maven version. When running both examples, I could see two requests every 5
seconds. Both of them are answered by the server. The “jobs” request is
answered identically. The difference seems to be in the “metrics” response:
The working version of the Gradle version produces this:
{
"jobId": "JOB_0",
"ops": [
{
"opId": "OP_2",
"metrics": [
{
"type": "counter",
"name": "Count",
"value": "219"
}
]
}
]
}
The Maven version however produces this:
{
"jobId": "JOB_0",
"ops": [
{
"opId": "OP_2",
"metrics": [
{
"type": "long",
"name": "Count",
"value": "436"
}
]
}
]
}
The difference seems to be that the “type” is “counter” in the working version
and “long” in the not working version. I tried debugging this, but I couldn’t
really understand why this is different.
Any ideas what could be wrong? I guess in general things should be working, all
we have to do is fix some final mini-quirks.
Chris
Am 18.09.17, 11:02 schrieb "Christofer Dutz" <[email protected]>:
Hi Dale,
last weekend I addressed your open points regarding the source releases.
One thing I should mention is that the editor files shouldn’t be a problem
as when using the maven-release-plugin the tagged version of the sources are
checked out and built. So there shouldn’t be any leftover files. This should
only be a problem when manually activating the “apache-release” profile.
I also I filled one of the two TODOs in the DEVELOPMENT.md file.
Added inline comments in the confluence page … will have a look at the
samples next.
Chris
Am 30.08.17, 18:44 schrieb "Dale LaBossiere" <[email protected]>:
Chris,
Simply stated: awesome progress while I’ve been out. Nice work!!!
I’m now starting to review all of the changes to bring myself up to
date.
I completely agree with the desire to merge asap… with emphasis on “as
possible” / “as practical” :-)
Hopefully I’ll reach your conclusion that now is the time.
— Dale
> On Aug 28, 2017, at 4:58 AM, Christofer Dutz
<[email protected]> wrote:
>
> Hi All,
>
> Ok so I double checked the confluence Maven vs Gradle page and think
I addressed the remaining open issues.
>
> The Site generation now works fine from my point of view.
>
> So, what’s left to do? Do we need any final changes?
>
> I think it would be good to do the merge back soon as I do think that
it does make it more difficult for others to contribute and/or makes it more
difficult for us to maintain the branch if others started contributing more.
>
> Chris
>
