On 7/30/13 3:12 PM, "OmPrakash Muppirala" <bigosma...@gmail.com> wrote:
>On Tue, Jul 30, 2013 at 9:08 AM, Alex Harui <aha...@adobe.com> wrote: > >> >> >> On 7/30/13 8:11 AM, "Tom Chiverton" <t...@extravision.com> wrote: >> >> >On 30/07/2013 16:05, Alex Harui wrote: >> >> Crap, modules/swfutils/src/java/flash/swf/tags/ProductInfo.java needs >> >Are we sure changing an externally visible string wont break any third >> >party tools ? >> >Maybe ones that are trying to spot Flex Applications by looking for it, >> >for instance ? >> Valid concern, but I still think we should change. >> > >> >Is this a good time to run a 'grep' over the source code for the work >> >'Adobe' then ? >> I did scan the compiler for "Adobe Flex". That was the only one I >>thought >> needed to change. There are other instances that are historical and >> should probably stay. >> >> >Could you please give us an idea on why this change is required and what >would be the repercussions? If you ask me, it is because the compiler for Apache Flex should be marking SWFs as created by Apache Flex, not Adobe Flex. Could it bust some analytics? I suppose so, but we are not affiliated with Adobe so we shouldn't be marking SWFs that way. > >Thanks, >Om > > > >> -Alex >> >>