+1
On Fri, Dec 19, 2014 at 8:45 PM, Robert Metzger <rmetz...@apache.org> wrote: > Hi guys, > > I vote to make this issue a release blocker: > https://issues.apache.org/jira/browse/FLINK-1225 > Two users ran into the issue within 2 days. The quickstart is mean to give > new users a good experience. > > On Tue, Dec 16, 2014 at 10:30 PM, Stephan Ewen <se...@apache.org> wrote: >> >> Hi! >> >> I forked a branch "release-0.8" and bumped the master version to >> "0.9-incubating-SNAPSHOT". >> >> The closure cleaner is merged. Robert has opened a PR for Kryo - I would >> suggest to merge that to "master", cherry-pick to "release-0.8" and then: >> Merry releasing! >> >> Greetings, >> Stephan >> >> >> >> On Tue, Dec 16, 2014 at 6:43 PM, Márton Balassi <balassi.mar...@gmail.com> >> wrote: >> > >> > @Timo&Stephan: The streaming code uses this since last week [1], Timo >> > starting working on the issue prior way before that - so it also has to >> do >> > with the streaming team pushing last minute features to be honest... >> > >> > Then are we waiting for the Java Clousure cleaner and the Kyro support, I >> > guess. >> > Aljoscha has already issued a PR for the former, some additional testing >> is >> > needed from the looks of it. [2] >> > >> > [1] >> > >> > >> https://git-wip-us.apache.org/repos/asf?p=incubator-flink.git;a=commit;h=51c1f67791307c2b9355171f7398d104befc8de5 >> > [2] https://github.com/apache/incubator-flink/pull/269 >> > >> > On Tue, Dec 16, 2014 at 5:52 PM, Timo Walther <fl...@twalthr.com> wrote: >> > > >> > > Yes, I also think so. Stability is more important. >> > > >> > > > Am 16.12.2014 um 17:46 schrieb Stephan Ewen <se...@apache.org>: >> > > > >> > > > Yes, the fact that we both did not realize that until now sort of >> > reveals >> > > > that there are more implications than anticipated. That is never good >> > for >> > > > "last minute" patches. >> > > > >> > > > That's why I would like to merge it into 0.8.1 and 0.9, rather than >> > 0.8.0 >> > > > That gives the code a bit more testing/use and us a bit more time to >> > > > thoroughly think the implications through. >> > > > >> > > >> On Tue, Dec 16, 2014 at 5:30 PM, Timo Walther <fl...@twalthr.com> >> > > wrote: >> > > >> >> > > >> Sorry I totally forgot to check the streaming API. Do they use the >> > > >> getXXXReturnTypes() methods of the TypeExtractor? >> > > >> >> > > >>> Am 16.12.2014 um 17:23 schrieb Robert Metzger <rmetz...@apache.org >> >: >> > > >>> >> > > >>> I've worked on adding Kryo support to Flink today. I would really >> > like >> > > to >> > > >>> include this into the release. Many users were complaining about >> > this ( >> > > >>> https://issues.apache.org/jira/browse/FLINK-610). >> > > >>> >> > > >>> I've based my work on top of Timo's pull request. If we're not >> going >> > to >> > > >>> merge it, I will have to rebase my code to the current master. ... >> > I'll >> > > >> try >> > > >>> and see if its easily doable. >> > > >>> >> > > >>>> On Tue, Dec 16, 2014 at 5:02 PM, Stephan Ewen <se...@apache.org> >> > > wrote: >> > > >>>> >> > > >>>> Yes, one thing I just realized is that the streaming API is not >> > aware >> > > of >> > > >>>> MissingTypeInfos and it may cause weird behavior. >> > > >>>> >> > > >>>>> On Tue, Dec 16, 2014 at 4:56 PM, Fabian Hueske < >> fhue...@gmail.com> >> > > >> wrote: >> > > >>>>> >> > > >>>>> +1 for stability first >> > > >>>>> >> > > >>>>> 2014-12-16 16:50 GMT+01:00 Stephan Ewen <se...@apache.org>: >> > > >>>>>> >> > > >>>>>> I am currently working through the type hints pull request... >> > > >>>>>> >> > > >>>>>> Right now, I actually think that we should postpone this for the >> > > next >> > > >>>>>> bugfix release. >> > > >>>>>> >> > > >>>>>> This pull request changes actually some tricky mechanisms in the >> > > Java >> > > >>>> API >> > > >>>>>> (it delays the type information), which may have implications >> that >> > > me >> > > >>>> and >> > > >>>>>> Timo have not fully caught now. >> > > >>>>>> >> > > >>>>>> I don't feel Merging this last minute - this is prone to >> introduce >> > > >>>>> errors. >> > > >>>>>> >> > > >>>>>> Any opinions on that? >> > > >>>>>> >> > > >>>>>> >> > > >>>>>> >> > > >>>>>> On Tue, Dec 16, 2014 at 3:36 PM, Stephan Ewen <se...@apache.org >> > >> > > >>>> wrote: >> > > >>>>>>> >> > > >>>>>>> +1 for adding the closure cleaner... >> > > >>>>>>> Am 16.12.2014 15:23 schrieb "Aljoscha Krettek" < >> > > aljos...@apache.org >> > > >>>>> : >> > > >>>>>>> >> > > >>>>>>> Do we want the Java Closure Cleaner in 0.8 as well? >> > > >>>>>>>> >> > > >>>>>>>> On Tue, Dec 16, 2014 at 10:30 AM, Márton Balassi >> > > >>>>>>>> <balassi.mar...@gmail.com> wrote: >> > > >>>>>>>>> Cool, thanks. >> > > >>>>>>>>> >> > > >>>>>>>>> On Tue, Dec 16, 2014 at 10:29 AM, Stephan Ewen < >> > se...@apache.org >> > > > >> > > >>>>>>>> wrote: >> > > >>>>>>>>>> >> > > >>>>>>>>>> Hi! >> > > >>>>>>>>>> >> > > >>>>>>>>>> The type hints PR is ready now, Timo made some final >> > adjustments >> > > >>>>>>>> yesterday >> > > >>>>>>>>>> evening. I'll review and merge it now, then we can fork the >> > > >>>> branch. >> > > >>>>>>>>>> >> > > >>>>>>>>>> Cheers, >> > > >>>>>>>>>> Stephan >> > > >>>>>>>>>> >> > > >>>>>>>>>> >> > > >>>>>>>>>> On Mon, Dec 15, 2014 at 10:08 PM, Márton Balassi < >> > > >>>>>>>> balassi.mar...@gmail.com >> > > >>>>>>>>>> wrote: >> > > >>>>>>>>>>> >> > > >>>>>>>>>>> Hey, >> > > >>>>>>>>>>> >> > > >>>>>>>>>>> Checking the PRs listed by Stephan it seems every import >> one >> > > >>>> has >> > > >>>>>> been >> > > >>>>>>>>>>> merged. As for the optional ones the following two are >> still >> > > >>>>>> pending: >> > > >>>>>>>>>>> >> > > >>>>>>>>>>> >> > > >>>>>>>>>>> Add support for Subclasses, Interfaces, Abstract Classes as >> > > >>>> POJOs >> > > >>>>>>>>>>> >> > > >>>>>>>>>>> [FLINK-1245] Introduce TypeHints for Java API operators >> > > >>>>>>>>>>> >> > > >>>>>>>>>>> >> > > >>>>>>>>>>> Robert +1'd the TypeHints PR and Timo has just updated it. >> > > >>>> Should >> > > >>>>>> we >> > > >>>>>>>> wait >> > > >>>>>>>>>>> for it? >> > > >>>>>>>>>>> >> > > >>>>>>>>>>> Cheers, >> > > >>>>>>>>>>> >> > > >>>>>>>>>>> Marton >> > > >>>>>>>>>>> >> > > >>>>>>>>>>> On Fri, Dec 12, 2014 at 2:29 PM, Ufuk Celebi < >> u...@apache.org >> > > >> > > >>>>>> wrote: >> > > >>>>>>>>>>>> >> > > >>>>>>>>>>>> On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen < >> > > >>>>> se...@apache.org> >> > > >>>>>>>>>> wrote: >> > > >>>>>>>>>>>>> >> > > >>>>>>>>>>>>> ---------------------------------------------- >> > > >>>>>>>>>>>>> Important Pull Requests to merge: >> > > >>>>>>>>>>>>> ---------------------------------------------- >> > > >>>>>>>>>>>>> >> > > >>>>>>>>>>>>> [FLINK-1287] LocalizableSplitAssigner prefers splits with >> > > >>>>> less >> > > >>>>>>>>>> degrees >> > > >>>>>>>>>>> of >> > > >>>>>>>>>>>>> freedom >> > > >>>>>>>>>>>>> >> > > >>>>>>>>>>>>> [FLINK-1305] [FLINK-1304] Test for HadoopInputWrapper and >> > > >>>>>>>>>> NullWritable >> > > >>>>>>>>>>>>> support >> > > >>>>>>>>>>>>> >> > > >>>>>>>>>>>>> Upgraded HBase addon to HBase 0.98.x and new Tuple APIs + >> > > >>>> fix >> > > >>>>>> of >> > > >>>>>>>>>>>>> ExecutionEnvironment >> > > >>>>>>>>>>>>> (this is partially merged, there are a few POM entries >> > > >>>>> missing >> > > >>>>>>>> for >> > > >>>>>>>>>>>> Hadoop 1 >> > > >>>>>>>>>>>>> support) >> > > >>>>>>>>>>>> >> > > >>>>>>>>>>>> The first two PRs are still open. I will have a look at >> them >> > > >>>> as >> > > >>>>>>>> well >> > > >>>>>>>>>>>> (Robert already tested one). >> > > >>>>>>>>>>>> >> > > >>>>>>>>>>>> @Robert: >> > > >>>>>>>>>>>> Regarding the Hbase PR: Is it resolved by 1b69749 ("Enable >> > > >>>>>>>> flink-hbase >> > > >>>>>>>>>>>> module for hadoop1 build as well")? >> > > >>>>>>>>>>>> >> > > >>>>>>>>>>>> >> > > >>>>>>>>>>>> It would be nice if had a look at the remaining important >> > > >>>> ones >> > > >>>>>>>> today. >> > > >>>>>>>>>> :-) >> > > >> >> > > >> > >>
