Based on the lack of “-1” votes, I have cherry-picked the change… Thanks, Mark
> On Nov 7, 2019, at 8:54 AM, Bruce Schuchardt <bschucha...@pivotal.io> wrote: > > The change passed in SSL benchmark testing and can be cherry-picked into the > release branch. The Benchmark job as a whole failed due to perf degradation > with the Security Manager, but that's a different set of tests. > > > On 11/6/19 3:57 PM, Helena Bales wrote: >> +1 to cherry-picking the fix. >> >> The sha hasn't made it to benchmarks yet due to an issue with CI losing >> resource refs that were needed to keep it moving through the pipeline. The >> next commit is still about an hour away from triggering benchmarks. >> In my manual benchmarking of this change, I found that it resolved the >> issue with SSL and passed the benchmarks. Obviously we still need to >> confirm that it works through the main pipeline, but I feel confident that >> it will pass the benchmark job. >> >> Thanks, >> Helena Bales (they/them) >> >> On Wed, Nov 6, 2019 at 9:28 AM Mark Hanson <mhan...@pivotal.io> wrote: >> >>> Any other votes? I have 2 people in favor. >>> >>> Voting will close at noon. >>> >>> Thanks, >>> Mark >>> >>>> On Nov 6, 2019, at 8:00 AM, Bruce Schuchardt <bschucha...@pivotal.io> >>> wrote: >>>> The fix for this problem is in the CI pipeline today: >>> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Build/builds/1341 >>>> On 11/5/19 10:49 AM, Owen Nichols wrote: >>>>> +1 for bringing this fix to release/1.11.0 (after it has passed >>> Benchmarks on develop) >>>>>> On Nov 5, 2019, at 10:45 AM, Bruce Schuchardt <bschucha...@pivotal.io> >>> wrote: >>>>>> The PR for GEODE-6661 introduced a problem in SSL communications that >>> needs to be fixed. It changed SSL handshakes to use a temporary buffer >>> that's discarded when the handshake completes, but sometimes this buffer >>> contains application data that must be retained. This seems to be causing >>> our Benchmark SSL test failures in CI. >>>>>> I'm preparing a fix. We can either revert the PR for GEODE-6661 on >>> that branch or cherry-pick the correction when it's ready. >>>
