Ok so here the counts: +1: 3 bindings, 1 non-binding 0: no -1: 2 non-bindings
Considering -1 were for an alpha we'll rerelease super fast this vote passes and I'll assume to rerun one for jms 2 api ASAP. Thanks you all guys to have reviewed it! Romain Manni-Bucau @rmannibucau http://www.tomitribe.com http://rmannibucau.wordpress.com https://github.com/rmannibucau 2015-02-12 14:01 GMT+01:00 Martyn Taylor <mtay...@redhat.com>: > On 12/02/15 09:43, Mark Struberg wrote: >> >> +1 (binding). Go on. It's just an -alpha release. We had that glitch >> already in the previous version. > > Fair enough. I have managed a successful ActiveMQ6 build against the > alpha-1, so the issues (for us at least) are non blocking. I'm happy to > proceed as suggested and incorporate the changes in a subsequent release. >> >> Just make sure it properly gets committed in time. >> If you don't have sufficient privileges to commit it yourself then just >> ping on the list for a review and apply. > > Yup, just sent a request for review. >> >> >> LieGrue, >> strub > > Thanks > Martyn > >> >> >> >> >> On Wednesday, 11 February 2015, 11:28, Martyn Taylor <mtay...@redhat.com> >> wrote: >> >> >>> >>> -1 (non-binding). There are a few issues with the JMS spec jar. There >>> is a PR open here: https://github.com/apache/geronimo-specs/pull/3 >>> >>> >>> On 09/02/15 19:20, Romain Manni-Bucau wrote: >>>> >>>> Hello guys, >>>> >>>> As announced few weeks ago let's try to release more alpha of our EE 7 >>>> spec jars. I added javamail as well since it got some nice fixes >>>> (thanks Hendrik mainly) which are important to release since I saw too >>>> much people replacing our implementation by javax one for small >>>> blocking bugs fixed since weeks on SNAPSHOTs. Also note this release >>>> train was mainly motivated by AMQ which is waiting JMS 2 API to >>>> release their version 6 (thanks to John D Ament for the patch on the >>>> API BTW). >>>> >>>> Here is the list of artifacts included in this vote: >>>> >>>> - geronimo-javamail_1.4 + geronimo-javamail_1.4_mail + >>>> geronimo-javamail_1.4_provider >>>> - geronimo-ejb_3.2_spec >>>> - geronimo-javamail_1.4_spec >>>> - geronimo-jaxrs_2.0_spec >>>> - geronimo-jms_2.0_spec >>>> - geronimo-jta_1.2_spec >>>> >>>> >>>> Here is the staging repo >>>> >>>> >>>> https://repository.apache.org/content/repositories/orgapachegeronimo-1012 >>>> >>>> I bet you will find the source/javadoc/etc yourself. >>>> >>>> My key can be found at >>>> https://svn.apache.org/repos/asf/geronimo/KEYS >>>> >>>> please VOTE >>>> [+1] all fine, ship it >>>> [+0] don't care >>>> [-1] stop, because ${reason} >>>> >>>> here is my +1 >>>> >>>> >>>> Romain Manni-Bucau >>>> @rmannibucau >>>> http://www.tomitribe.com >>>> http://rmannibucau.wordpress.com >>>> https://github.com/rmannibucau >>> >>> >>> >>> >
