[
https://issues.apache.org/jira/browse/GOBBLIN-1921?focusedWorklogId=882966&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882966
]
ASF GitHub Bot logged work on GOBBLIN-1921:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Oct/23 17:49
Start Date: 02/Oct/23 17:49
Worklog Time Spent: 10m
Work Description: umustafi opened a new pull request, #3790:
URL: https://github.com/apache/gobblin/pull/3790
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1921
### Description
- [X] Here are some details about my PR, including screenshots (if
applicable):
Reminder flow trigger events were being improperly handled and interpreted
as new events because they are triggered linger time after the original trigger
where epsilon < linger and we use epsilon to determine event distinctness. With
reminder events being considered distinct events, we were launching excess
concurrent flows that were then being cancelled. Now we handle reminder events
differently from normal event triggers to ensure they're properly evaluated.
Because of db laundering, reminder events are easy to handle - if they're older
than the currently worked upon event in the database they can be skipped and if
they're equal to the current event in the database they are handled like
normal. Reminder events should never be newer than the current event in the
lease arbiter table because db laundering always results in increasing event
times.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Updates existing unit tests
TODO: adding tests to handle reminder events
### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 882966)
Remaining Estimate: 0h
Time Spent: 10m
> Properly handle reminder events
> -------------------------------
>
> Key: GOBBLIN-1921
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1921
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Reminder flow trigger events were being improperly handled and interpreted as
> new events because they are triggered {{linger}} time after the original
> trigger where {{epsilon < linger}} and we use {{epsilon}} to determine event
> distinctness. With reminder events being considered distinct events, we were
> launching excess concurrent flows that were then being cancelled. Now we
> handle reminder events differently from normal event triggers to ensure
> they're properly evaluated. Because of db laundering, reminder events are
> easy to handle - if they're older than the currently worked upon event in the
> database they can be skipped and if they're equal to the current event in the
> database they are handled like normal. Reminder events should never be newer
> than the current event in the lease arbiter table because db laundering
> always results in increasing event times.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
