[
https://issues.apache.org/jira/browse/GOBBLIN-1921?focusedWorklogId=883000&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-883000
]
ASF GitHub Bot logged work on GOBBLIN-1921:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Oct/23 21:15
Start Date: 02/Oct/23 21:15
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3790:
URL: https://github.com/apache/gobblin/pull/3790#issuecomment-1743777538
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3790?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
> Merging
[#3790](https://app.codecov.io/gh/apache/gobblin/pull/3790?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(d0aa450) into
[master](https://app.codecov.io/gh/apache/gobblin/commit/028b85f587e3c1e6afa5d8662fe9ed3f0087568d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(028b85f) will **decrease** coverage by `1.21%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3790 +/- ##
============================================
- Coverage 47.32% 46.12% -1.21%
+ Complexity 10955 2183 -8772
============================================
Files 2152 416 -1736
Lines 85114 17965 -67149
Branches 9451 2191 -7260
============================================
- Hits 40279 8286 -31993
+ Misses 41184 8797 -32387
+ Partials 3651 882 -2769
```
[see 1745 files with indirect coverage
changes](https://app.codecov.io/gh/apache/gobblin/pull/3790/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Issue Time Tracking
-------------------
Worklog Id: (was: 883000)
Time Spent: 1h 40m (was: 1.5h)
> Properly handle reminder events
> -------------------------------
>
> Key: GOBBLIN-1921
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1921
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Reminder flow trigger events were being improperly handled and interpreted as
> new events because they are triggered {{linger}} time after the original
> trigger where {{epsilon < linger}} and we use {{epsilon}} to determine event
> distinctness. With reminder events being considered distinct events, we were
> launching excess concurrent flows that were then being cancelled. Now we
> handle reminder events differently from normal event triggers to ensure
> they're properly evaluated. Because of db laundering, reminder events are
> easy to handle - if they're older than the currently worked upon event in the
> database they can be skipped and if they're equal to the current event in the
> database they are handled like normal. Reminder events should never be newer
> than the current event in the lease arbiter table because db laundering
> always results in increasing event times.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
