phet commented on code in PR #3823:
URL: https://github.com/apache/gobblin/pull/3823#discussion_r1388721063
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/FlowSpec.java:
##########
@@ -125,6 +125,18 @@ public static FlowSpec.Builder builder(URI catalogURI,
Properties flowProps) {
throw new RuntimeException("Unable to create a FlowSpec URI: " + e, e);
}
}
+
+ /**
+ * Add new property at the specified path to the configAsProperties objects.
+ * Note: this does NOT update the Config so any property added through this
function must be retrieved through the
+ * ConfigAsProperties field
Review Comment:
may be error prone... why not instead create a new `Config` and update the
reference to point to that one? given immutability, k-v pairs in common (the
vast majority) should be readily shared, for minimal performance penalty. I
believe you'd create the successor using `Config::withFallback` (but I'm not
100% sure)
do be sure to synchronize an update of `configAsProperties` at that same
time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
