arjun4084346 commented on code in PR #3823:
URL: https://github.com/apache/gobblin/pull/3823#discussion_r1388949632
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java:
##########
@@ -484,7 +484,9 @@ public synchronized void setActive(boolean active) {
log.error("Exception encountered when shutting down DagManager
threads.", e);
}
}
- } catch (IOException e) {
+ } catch (Throwable e) {
Review Comment:
1) why do we set this.active=true when it is not ready yet to act as a
leader?
2) should we just reverse the leadership change in the catch block then?
3) basically the only difference this change is making is printing a log
line. lets try to handle the exception(including runtime) gracefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
