arjun4084346 commented on code in PR #3823:
URL: https://github.com/apache/gobblin/pull/3823#discussion_r1388945579
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java:
##########
@@ -203,8 +203,8 @@ protected void submitFlowToDagManagerHelper(String
flowGroup, String flowName, S
URI flowUri = FlowSpec.Utils.createFlowSpecUri(flowId);
spec = (FlowSpec) flowCatalog.getSpecs(flowUri);
// Adds flowExecutionId to config to ensure they are consistent across
hosts
- FlowSpec updatedSpec = FlowSpec.Utils.createFlowSpecWithProperty(spec,
ConfigurationKeys.FLOW_EXECUTION_ID_KEY, flowExecutionId);
- this.orchestrator.submitFlowToDagManager(updatedSpec);
+
spec.addPropertyToConfigAsProperties(ConfigurationKeys.FLOW_EXECUTION_ID_KEY,
flowExecutionId);
Review Comment:
This is where we add flow.execution.id.
In li-gobblin AzkabanHeadlessProducer we get the configs
`Map<String, String> flowParameters = new
HashMap<>(Maps.fromProperties(ConfigUtils.configToProperties(jobConfig)));`
and there we use configs from `config` object. so you have to make change
there also, if you want this approach to work. lets think more thoroughly which
approach is better and more intuitive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
