[
https://issues.apache.org/jira/browse/GOBBLIN-2032?focusedWorklogId=912530&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-912530
]
ASF GitHub Bot logged work on GOBBLIN-2032:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Apr/24 21:40
Start Date: 01/Apr/24 21:40
Worklog Time Spent: 10m
Work Description: Will-Lo opened a new pull request, #3911:
URL: https://github.com/apache/gobblin/pull/3911
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-2032
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
In Gobblin cluster, there is a configuration to set the log sink in order to
create a log copier service which copies logs to HDFS from Yarn cluster.
This PR makes the configuration for log dir sinks optional so that the
application does not need to set up a log copying service. Additionally it
makes the file name suffix configurable in case the user wants a non-stdout
file.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Ran E2E, confirms it works without log dir sinks set up.
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 912530)
Remaining Estimate: 0h
Time Spent: 10m
> Support making log dir sink optional
> ------------------------------------
>
> Key: GOBBLIN-2032
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2032
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-cluster
> Reporter: William Lo
> Assignee: Hung Tran
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In Gobblin cluster, there is a configuration to set the log sink in order to
> create a log copier service which copies logs to HDFS from Yarn cluster.
> Since Yarn has a built in log aggregator, we should have a way to disable
> this log sink since it becomes redundant, so we should look into ways to make
> the log directory optional.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
