[
https://issues.apache.org/jira/browse/GOBBLIN-2032?focusedWorklogId=912532&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-912532
]
ASF GitHub Bot logged work on GOBBLIN-2032:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Apr/24 21:53
Start Date: 01/Apr/24 21:53
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3911:
URL: https://github.com/apache/gobblin/pull/3911#issuecomment-2030629570
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3911?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
Attention: Patch coverage is `0%` with `8 lines` in your changes are missing
coverage. Please review.
> Project coverage is 41.30%. Comparing base
[(`fbd4ee8`)](https://app.codecov.io/gh/apache/gobblin/commit/fbd4ee8e8b7a57d5f44f6cf0e887d0eb029b94aa?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
to head
[(`3264893`)](https://app.codecov.io/gh/apache/gobblin/pull/3911?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 8 commits behind head on master.
|
[Files](https://app.codecov.io/gh/apache/gobblin/pull/3911?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[...emporal/yarn/GobblinTemporalApplicationMaster.java](https://app.codecov.io/gh/apache/gobblin/pull/3911?src=pr&el=tree&filepath=gobblin-temporal%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgobblin%2Ftemporal%2Fyarn%2FGobblinTemporalApplicationMaster.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi10ZW1wb3JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi90ZW1wb3JhbC95YXJuL0dvYmJsaW5UZW1wb3JhbEFwcGxpY2F0aW9uTWFzdGVyLmphdmE=)
| 0.00% | [7 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/3911?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[...emporal/ddm/workflow/impl/CleanupWorkflowImpl.java](https://app.codecov.io/gh/apache/gobblin/pull/3911?src=pr&el=tree&filepath=gobblin-temporal%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgobblin%2Ftemporal%2Fddm%2Fworkflow%2Fimpl%2FCleanupWorkflowImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi10ZW1wb3JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi90ZW1wb3JhbC9kZG0vd29ya2Zsb3cvaW1wbC9DbGVhbnVwV29ya2Zsb3dJbXBsLmphdmE=)
| 0.00% | [1 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/3911?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3911 +/- ##
============================================
- Coverage 46.61% 41.30% -5.32%
+ Complexity 11217 2194 -9023
============================================
Files 2240 476 -1764
Lines 88334 20176 -68158
Branches 9672 2338 -7334
============================================
- Hits 41181 8333 -32848
+ Misses 43441 10959 -32482
+ Partials 3712 884 -2828
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/gobblin/pull/3911?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
Issue Time Tracking
-------------------
Worklog Id: (was: 912532)
Time Spent: 20m (was: 10m)
> Support making log dir sink optional
> ------------------------------------
>
> Key: GOBBLIN-2032
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2032
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-cluster
> Reporter: William Lo
> Assignee: Hung Tran
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In Gobblin cluster, there is a configuration to set the log sink in order to
> create a log copier service which copies logs to HDFS from Yarn cluster.
> Since Yarn has a built in log aggregator, we should have a way to disable
> this log sink since it becomes redundant, so we should look into ways to make
> the log directory optional.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
