[
https://issues.apache.org/jira/browse/GOBBLIN-2032?focusedWorklogId=912916&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-912916
]
ASF GitHub Bot logged work on GOBBLIN-2032:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Apr/24 21:24
Start Date: 03/Apr/24 21:24
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3911:
URL: https://github.com/apache/gobblin/pull/3911#discussion_r1550515929
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java:
##########
@@ -269,7 +269,8 @@ public GobblinYarnAppLauncher(Config config,
YarnConfiguration yarnConfiguration
Optional.of(config.getString(GobblinYarnConfigurationKeys.APP_MASTER_JVM_ARGS_KEY))
:
Optional.<String>absent();
- this.sinkLogRootDir = new
Path(config.getString(GobblinYarnConfigurationKeys.LOGS_SINK_ROOT_DIR_KEY));
+ this.sinkLogRootDir =
config.hasPath(GobblinYarnConfigurationKeys.LOGS_SINK_ROOT_DIR_KEY) ?
+ new
Path(config.getString(GobblinYarnConfigurationKeys.LOGS_SINK_ROOT_DIR_KEY)) :
null;
Review Comment:
couldn't this be `ConfigUtils.getString(theKey, null)`?
Issue Time Tracking
-------------------
Worklog Id: (was: 912916)
Time Spent: 50m (was: 40m)
> Support making log dir sink optional
> ------------------------------------
>
> Key: GOBBLIN-2032
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2032
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-cluster
> Reporter: William Lo
> Assignee: Hung Tran
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> In Gobblin cluster, there is a configuration to set the log sink in order to
> create a log copier service which copies logs to HDFS from Yarn cluster.
> Since Yarn has a built in log aggregator, we should have a way to disable
> this log sink since it becomes redundant, so we should look into ways to make
> the log directory optional.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
