[
https://issues.apache.org/jira/browse/GOBBLIN-2032?focusedWorklogId=913515&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-913515
]
ASF GitHub Bot logged work on GOBBLIN-2032:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Apr/24 20:10
Start Date: 08/Apr/24 20:10
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3911:
URL: https://github.com/apache/gobblin/pull/3911#discussion_r1556382308
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java:
##########
@@ -204,7 +204,7 @@ public class GobblinYarnAppLauncher {
private final Optional<String> appMasterJvmArgs;
- private final Path sinkLogRootDir;
+ private final String sinkLogRootDir;
Review Comment:
Nope because we create a new Path using this string, but omit creating the
path if it's null.
https://github.com/apache/gobblin/blob/b08ad65948deedc00c94e828ba5a76c9578cb93c/gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java#L379
Issue Time Tracking
-------------------
Worklog Id: (was: 913515)
Time Spent: 1h 20m (was: 1h 10m)
> Support making log dir sink optional
> ------------------------------------
>
> Key: GOBBLIN-2032
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2032
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-cluster
> Reporter: William Lo
> Assignee: Hung Tran
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> In Gobblin cluster, there is a configuration to set the log sink in order to
> create a log copier service which copies logs to HDFS from Yarn cluster.
> Since Yarn has a built in log aggregator, we should have a way to disable
> this log sink since it becomes redundant, so we should look into ways to make
> the log directory optional.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
