arpit09 opened a new pull request, #3913:
URL: https://github.com/apache/gobblin/pull/3913

   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following 
[GOBBLIN-2026](https://issues.apache.org/jira/browse/GOBBLIN-2026) issues and 
references them in the PR title. 
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if 
applicable):
      - Currently in the cleaner job, if the OOM error occurs while fetching 
dataset versions. We add it to the throwables and then continue with the 
execution job of cleaning other dataset versions. This leads to execution going 
to the finally clause where the job is exited successfully. With the changes in 
the PR, whenever an OOM error occurs it won't be consumed, will be thrown then 
and there. 
      - Due to the changes done in 
[PR](https://github.com/apache/gobblin/pull/3883) the log where no deletable 
version exists was being printed for every 100 datasets. This PR avoids writing 
log when there are no deletable versions.
   
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to