arpit09 commented on code in PR #3913:
URL: https://github.com/apache/gobblin/pull/3913#discussion_r1551465590
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/retention/dataset/MultiVersionCleanableDatasetBase.java:
##########
@@ -327,7 +327,9 @@ private boolean cleanDatasetVersions(List<T> versions,
VersionSelectionPolicy<T>
boolean isCleanSuccess = true;
Collections.sort(versions, Collections.reverseOrder());
Collection<T> deletableVersions =
selectionPolicy.listSelectedVersions(versions);
- cleanImpl(deletableVersions);
+ if (!deletableVersions.isEmpty()) {
Review Comment:
Thanks for pointing out, fixed it by passing the variable
`shouldLogDeletableVersion` via caller
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
