arjun4084346 commented on code in PR #3913:
URL: https://github.com/apache/gobblin/pull/3913#discussion_r1550702127
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/retention/dataset/MultiVersionCleanableDatasetBase.java:
##########
@@ -327,7 +327,9 @@ private boolean cleanDatasetVersions(List<T> versions,
VersionSelectionPolicy<T>
boolean isCleanSuccess = true;
Collections.sort(versions, Collections.reverseOrder());
Collection<T> deletableVersions =
selectionPolicy.listSelectedVersions(versions);
- cleanImpl(deletableVersions);
+ if (!deletableVersions.isEmpty()) {
Review Comment:
but then it will never print that log line.
can you distinguish the case when the caller has that iterator config set? i
see there are `properties` coming into the constructor of this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
