arpit09 commented on code in PR #3913:
URL: https://github.com/apache/gobblin/pull/3913#discussion_r1551462586
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/retention/DatasetCleaner.java:
##########
@@ -155,6 +155,9 @@ public Void call() throws Exception {
public void onFailure(Throwable throwable) {
DatasetCleaner.this.finishCleanSignal.get().countDown();
LOG.warn("Exception caught when cleaning " + dataset.datasetURN() +
".", throwable);
+ if (throwable instanceof OutOfMemoryError) {
Review Comment:
When OutofMemoryError occurs, there might be some heap space remaining for
the execution of finally block. As we are consuming it in the throwable, the
`RuntimeException` never gets executed in `close` resulting to go to finally
block (where the Executor service gracefully shutdowns the process)
Was able to replay this test case in my local.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
