[
https://issues.apache.org/jira/browse/GOBBLIN-2121?focusedWorklogId=928574&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928574
]
ASF GitHub Bot logged work on GOBBLIN-2121:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Aug/24 20:07
Start Date: 02/Aug/24 20:07
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #4012:
URL: https://github.com/apache/gobblin/pull/4012#discussion_r1702273840
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagProcessingEngine.java:
##########
@@ -140,6 +153,11 @@ public void run() {
dagTask.conclude();
} catch (Exception e) {
log.error("DagProcEngineThread encountered exception while
processing dag " + dagProc.getDagId(), e);
+ if (KafkaJobStatusMonitor.isThrowableInstanceOf(e,
this.nonRetryableExceptions)) {
+ // conclude the lease so that it is not retried, if the dag proc
fails with non-transient exception
+ dagTask.conclude();
+
dagManagementStateStore.getDagManagerMetrics().dagProcessingNonRetryableExceptionMeter.mark();
Review Comment:
good point. really I'm just seeking better encapsulation within `DagProc`,
so the DPE remains blissfully unaware of what they're doing and hence what
exceptions they might throw.
most ideal might be each `DagProc` class to know which of its exceptions are
transient. e.g. a base class method `boolean isTransientException(Throwable
t)`, with a common base class version and any derived class extending beyond
that (while delegating to the base class impl as a fallback).
if for expedience, you want a small step in the right direction that would
be for the factory to be initialized w/ a predicate as I suggested - given it's
the one who decides which specific `DagProc` derived class impls to use.
but after considering further, I really think
`DagProc::isTransientException` is preferable.
Issue Time Tracking
-------------------
Worklog Id: (was: 928574)
Time Spent: 3h (was: 2h 50m)
> redirect kill requests to dag proc engine
> ------------------------------------------
>
> Key: GOBBLIN-2121
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2121
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 3h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
