[
https://issues.apache.org/jira/browse/GOBBLIN-2121?focusedWorklogId=928600&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928600
]
ASF GitHub Bot logged work on GOBBLIN-2121:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Aug/24 00:15
Start Date: 03/Aug/24 00:15
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #4015:
URL: https://github.com/apache/gobblin/pull/4015#discussion_r1702415321
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/DeadlineEnforcementDagProc.java:
##########
@@ -68,7 +68,7 @@ protected boolean
isDagStillPresent(Optional<Dag<JobExecutionPlan>> dag, DagMana
if (!dagManagementStateStore.existsJobDagAction(dagAction.getFlowGroup(),
dagAction.getFlowName(),
dagAction.getFlowExecutionId(), dagAction.getJobName(),
dagAction.getDagActionType())) {
- log.warn("Dag action {} is cleaned up from DMSS. No further action is
required.", dagAction);
+ log.info("Dag action {} is cleaned up from DMSS. No further action is
required.", dagAction);
Review Comment:
what's your take
[here](https://github.com/apache/gobblin/pull/4012#discussion_r1701588762)?
to repeat:
> don't we already hold a lease by the time act is called? if so, it would
be exceedingly rare (and really no different than any other DagProc::act
derived class impl). given the rarity, I'd suggest to remove.
>
> but if we really believe we need this, let's observe the commonality by
placing this impl within the DagProc base class
Issue Time Tracking
-------------------
Worklog Id: (was: 928600)
Time Spent: 3.5h (was: 3h 20m)
> redirect kill requests to dag proc engine
> ------------------------------------------
>
> Key: GOBBLIN-2121
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2121
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
