[ 
https://issues.apache.org/jira/browse/GOBBLIN-2121?focusedWorklogId=928605&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928605
 ]

ASF GitHub Bot logged work on GOBBLIN-2121:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Aug/24 01:26
            Start Date: 03/Aug/24 01:26
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on code in PR #4015:
URL: https://github.com/apache/gobblin/pull/4015#discussion_r1702427655


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/DeadlineEnforcementDagProc.java:
##########
@@ -68,7 +68,7 @@ protected boolean 
isDagStillPresent(Optional<Dag<JobExecutionPlan>> dag, DagMana
 
     if (!dagManagementStateStore.existsJobDagAction(dagAction.getFlowGroup(), 
dagAction.getFlowName(),
         dagAction.getFlowExecutionId(), dagAction.getJobName(), 
dagAction.getDagActionType())) {
-      log.warn("Dag action {} is cleaned up from DMSS. No further action is 
required.", dagAction);
+      log.info("Dag action {} is cleaned up from DMSS. No further action is 
required.", dagAction);

Review Comment:
   i would say lets keep it here, because this is the only case where one dag 
action can be cleaned up by other type of dag proc.
   otherwise maintainers will keep wondering if there is some general 
conditions, irrespective of the type of dag actions, that can cause this





Issue Time Tracking
-------------------

    Worklog Id:     (was: 928605)
    Time Spent: 3h 50m  (was: 3h 40m)

>  redirect kill requests to dag proc engine
> ------------------------------------------
>
>                 Key: GOBBLIN-2121
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2121
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 3h 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to