[
https://issues.apache.org/jira/browse/GOBBLIN-2159?focusedWorklogId=939490&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-939490
]
ASF GitHub Bot logged work on GOBBLIN-2159:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Oct/24 13:16
Start Date: 22/Oct/24 13:16
Worklog Time Spent: 10m
Work Description: Blazer-007 commented on code in PR #4058:
URL: https://github.com/apache/gobblin/pull/4058#discussion_r1810304986
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/BaseIcebergCatalog.java:
##########
@@ -43,7 +44,10 @@ protected BaseIcebergCatalog(String catalogName, Class<?
extends Catalog> compan
@Override
public IcebergTable openTable(String dbName, String tableName) {
TableIdentifier tableId = TableIdentifier.of(dbName, tableName);
- return new IcebergTable(tableId, calcDatasetDescriptorName(tableId),
getDatasetDescriptorPlatform(), createTableOperations(tableId),
this.getCatalogUri());
+ return new IcebergTable(tableId, calcDatasetDescriptorName(tableId),
getDatasetDescriptorPlatform(),
+ createTableOperations(tableId),
+ this.getCatalogUri(),
+ loadTableInstance(tableId));
Review Comment:
Yes it arise from `loadTableInstance` or more specifically from
`catalog.loadTable(tableIdentifier)` and i dont believe it will be easy to
catch it and rethrow as `IcebergTable.TableNotFoundException` because this
exception arises before creating IcebergTable instance itself as opposite to
catalog.newTableOps(tableIdentifier) which doesn't throw this exception while
initializing rather it throws when used for first time inside IcebergTable.
Please let me know your thoughts on this if we really want to throw
`IcebergTable.TableNotFoundException` itself in catalog only
Issue Time Tracking
-------------------
Worklog Id: (was: 939490)
Time Spent: 8h 50m (was: 8h 40m)
> Support Partition Based Copy in Iceberg Distcp
> ----------------------------------------------
>
> Key: GOBBLIN-2159
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2159
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Vivek Rai
> Priority: Major
> Time Spent: 8h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
