[
https://issues.apache.org/jira/browse/GOBBLIN-2159?focusedWorklogId=939582&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-939582
]
ASF GitHub Bot logged work on GOBBLIN-2159:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Oct/24 21:16
Start Date: 22/Oct/24 21:16
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #4058:
URL: https://github.com/apache/gobblin/pull/4058#discussion_r1811453063
##########
gobblin-data-management/src/test/java/org/apache/gobblin/data/management/copy/iceberg/IcebergTableTest.java:
##########
@@ -106,15 +113,17 @@ public void testGetCurrentSnapshotInfo() throws
IOException {
);
initializeSnapshots(table, perSnapshotFilesets);
- IcebergSnapshotInfo snapshotInfo = new IcebergTable(tableId,
catalog.newTableOps(tableId), catalogUri).getCurrentSnapshotInfo();
+ IcebergSnapshotInfo snapshotInfo = new IcebergTable(tableId,
catalog.newTableOps(tableId), catalogUri,
+ catalog.loadTable(tableId)).getCurrentSnapshotInfo();
verifySnapshotInfo(snapshotInfo, perSnapshotFilesets,
perSnapshotFilesets.size());
}
/** Verify failure when attempting to get current snapshot info for
non-existent table */
- @Test(expectedExceptions = IcebergTable.TableNotFoundException.class)
+ @Test(expectedExceptions = {IcebergTable.TableNotFoundException.class,
NoSuchTableException.class})
Review Comment:
exactly, change `loadTable` to catch any other exception and instead throw
our `IcebergTable.TableNotFoundException`. let underlying impl methods throw
what they may, but just wrap the call to intercept the that apache.iceberg
`NoSuchTableException` so it doesn't leak through
Issue Time Tracking
-------------------
Worklog Id: (was: 939582)
Time Spent: 9h 40m (was: 9.5h)
> Support Partition Based Copy in Iceberg Distcp
> ----------------------------------------------
>
> Key: GOBBLIN-2159
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2159
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Vivek Rai
> Priority: Major
> Time Spent: 9h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
