[
https://issues.apache.org/jira/browse/GOBBLIN-2159?focusedWorklogId=939584&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-939584
]
ASF GitHub Bot logged work on GOBBLIN-2159:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Oct/24 21:19
Start Date: 22/Oct/24 21:19
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #4058:
URL: https://github.com/apache/gobblin/pull/4058#discussion_r1811456671
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/BaseIcebergCatalog.java:
##########
@@ -43,7 +44,10 @@ protected BaseIcebergCatalog(String catalogName, Class<?
extends Catalog> compan
@Override
public IcebergTable openTable(String dbName, String tableName) {
TableIdentifier tableId = TableIdentifier.of(dbName, tableName);
- return new IcebergTable(tableId, calcDatasetDescriptorName(tableId),
getDatasetDescriptorPlatform(), createTableOperations(tableId),
this.getCatalogUri());
+ return new IcebergTable(tableId, calcDatasetDescriptorName(tableId),
getDatasetDescriptorPlatform(),
+ createTableOperations(tableId),
+ this.getCatalogUri(),
+ loadTableInstance(tableId));
Review Comment:
it's OK to raise the exception at creation time rather than upon first-use.
in fact, that's arguably even better
Issue Time Tracking
-------------------
Worklog Id: (was: 939584)
Time Spent: 9h 50m (was: 9h 40m)
> Support Partition Based Copy in Iceberg Distcp
> ----------------------------------------------
>
> Key: GOBBLIN-2159
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2159
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Vivek Rai
> Priority: Major
> Time Spent: 9h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
