[
https://issues.apache.org/jira/browse/GOBBLIN-2159?focusedWorklogId=939587&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-939587
]
ASF GitHub Bot logged work on GOBBLIN-2159:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Oct/24 21:28
Start Date: 22/Oct/24 21:28
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #4058:
URL: https://github.com/apache/gobblin/pull/4058#discussion_r1811463854
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/BaseIcebergCatalog.java:
##########
@@ -67,4 +71,6 @@ protected String getDatasetDescriptorPlatform() {
}
protected abstract TableOperations createTableOperations(TableIdentifier
tableId);
+
+ protected abstract Table loadTableInstance(TableIdentifier tableId);
Review Comment:
for good measure you could also make `IcebergTable.TableNotFoundException` a
declared/checked exception here.
I'm tempted to re-situate the exception as
`IcebergCatalog.TableNotFoundException`, but I don't want two classes w/ the
same semantics - and renaming public interfaces is probably too late... so I'll
make peace with the current name
Issue Time Tracking
-------------------
Worklog Id: (was: 939587)
Time Spent: 10h 10m (was: 10h)
> Support Partition Based Copy in Iceberg Distcp
> ----------------------------------------------
>
> Key: GOBBLIN-2159
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2159
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Vivek Rai
> Priority: Major
> Time Spent: 10h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
