[
https://issues.apache.org/jira/browse/GOBBLIN-2159?focusedWorklogId=939680&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-939680
]
ASF GitHub Bot logged work on GOBBLIN-2159:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Oct/24 10:59
Start Date: 23/Oct/24 10:59
Worklog Time Spent: 10m
Work Description: Blazer-007 commented on code in PR #4058:
URL: https://github.com/apache/gobblin/pull/4058#discussion_r1812489697
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergPartitionDataset.java:
##########
@@ -183,16 +187,20 @@ private Path addUUIDToPath(String filePathStr) {
return new Path(fileDir, newFileName);
}
- private Map<Path, FileStatus>
getDestFilePathWithSrcFileStatus(List<DataFile> srcDataFiles,
- List<DataFile> destDataFiles, FileSystem fs) throws IOException {
- Map<Path, FileStatus> results = Maps.newHashMap();
- for (int i = 0; i < srcDataFiles.size(); i++) {
- Path srcPath = new Path(srcDataFiles.get(i).path().toString());
- Path destPath = new Path(destDataFiles.get(i).path().toString());
- FileStatus srcFileStatus = fs.getFileStatus(srcPath);
- results.put(destPath, srcFileStatus);
- }
- return results;
+ private Map<Path, FileStatus> calcSrcFileStatusByDestFilePath(Map<Path,
DataFile> destDataFileBySrcPath) {
+ Map<Path, FileStatus> srcFileStatusByDestFilePath = Maps.newHashMap();
+ destDataFileBySrcPath.forEach((srcPath, destDataFile) -> {
+ FileStatus srcFileStatus;
+ try {
+ srcFileStatus = this.sourceFs.getFileStatus(srcPath);
+ } catch (IOException e) {
+ String errMsg = String.format("~%s~ Failed to get file status for path
: %s", this.getFileSetId(), srcPath);
+ log.error(errMsg);
+ throw new RuntimeException(errMsg, e);
+ }
Review Comment:
Done using [IcebergDataset's
use](https://github.com/apache/gobblin/blob/af4b822a1e2f79721cdff617f1581e77ff261580/gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergDataset.java#L205)
of
[CheckedExceptionFunction.wrapToTunneled](https://github.com/apache/gobblin/blob/585298fb5ebc074f69c1b9db87de6186c4855b26/gobblin-utility/src/main/java/org/apache/gobblin/util/function/CheckedExceptionFunction.java#L69)
Issue Time Tracking
-------------------
Worklog Id: (was: 939680)
Time Spent: 11.5h (was: 11h 20m)
> Support Partition Based Copy in Iceberg Distcp
> ----------------------------------------------
>
> Key: GOBBLIN-2159
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2159
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Vivek Rai
> Priority: Major
> Time Spent: 11.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
