[
https://issues.apache.org/jira/browse/GOBBLIN-2159?focusedWorklogId=939644&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-939644
]
ASF GitHub Bot logged work on GOBBLIN-2159:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Oct/24 08:00
Start Date: 23/Oct/24 08:00
Worklog Time Spent: 10m
Work Description: Blazer-007 commented on code in PR #4058:
URL: https://github.com/apache/gobblin/pull/4058#discussion_r1812118101
##########
gobblin-data-management/src/test/java/org/apache/gobblin/data/management/copy/iceberg/IcebergPartitionDatasetTest.java:
##########
@@ -190,8 +165,8 @@ public void testMultipleCopyEntitiesGenerated() throws
IOException {
srcFilePaths.add(SRC_WRITE_LOCATION + "/file4.orc");
srcFilePaths.add(SRC_WRITE_LOCATION + "/file5.orc");
- List<DataFile> srcDataFiles = getDataFiles();
-
Mockito.when(srcIcebergTable.getPartitionSpecificDataFiles(Mockito.any())).thenReturn(srcDataFiles);
+ List<DataFile> mockSrcDataFiles = createDataFileMocks();
+
Mockito.when(srcIcebergTable.getPartitionSpecificDataFiles(Mockito.any())).thenReturn(mockSrcDataFiles);
Review Comment:
srcfilePaths depend on type of tests that I have written like for testing
all scenarios of empty srcfile one srcfile and many srcfile that's why these
two lines have to be repeated
Issue Time Tracking
-------------------
Worklog Id: (was: 939644)
Time Spent: 11h (was: 10h 50m)
> Support Partition Based Copy in Iceberg Distcp
> ----------------------------------------------
>
> Key: GOBBLIN-2159
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2159
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Vivek Rai
> Priority: Major
> Time Spent: 11h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
