[
https://issues.apache.org/jira/browse/GOBBLIN-2194?focusedWorklogId=956948&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-956948
]
ASF GitHub Bot logged work on GOBBLIN-2194:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Feb/25 18:24
Start Date: 13/Feb/25 18:24
Worklog Time Spent: 10m
Work Description: abhishekmjain opened a new pull request, #4097:
URL: https://github.com/apache/gobblin/pull/4097
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN-2194) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-2194
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
As part of https://github.com/apache/gobblin/pull/4095, a bug was introduced
where the Metrics Scope object was not being closed, resulting in a non-daemon
thread being alive. This resulted in AM container not getting shut down on
application completion.
This PR implements the fix to close metrics scope wherever it is
initialized.
It also covers calling close on JobLauncher upon its completion, which now
results in cleanly closing the resources launched by JobLauncher.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Tested in a local project where the application master shuts down.
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 956948)
Remaining Estimate: 0h
Time Spent: 10m
> Fix Temporal metrics scope closure bug
> --------------------------------------
>
> Key: GOBBLIN-2194
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2194
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-metrics
> Reporter: Abhishek Jain
> Assignee: Issac Buenrostro
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As part of https://issues.apache.org/jira/browse/GOBBLIN-2192 a bug was
> introduced where the metrics scope object was not closed resulting in AM
> container not shutting down.
> Metrics scope should be closed wherever initialized.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
