[
https://issues.apache.org/jira/browse/GOBBLIN-2194?focusedWorklogId=957047&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-957047
]
ASF GitHub Bot logged work on GOBBLIN-2194:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Feb/25 07:19
Start Date: 14/Feb/25 07:19
Worklog Time Spent: 10m
Work Description: Blazer-007 commented on code in PR #4097:
URL: https://github.com/apache/gobblin/pull/4097#discussion_r1955659676
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/joblauncher/GobblinJobLauncher.java:
##########
@@ -137,7 +137,9 @@ public GobblinJobLauncher(Properties jobProps, Path
appWorkDir,
@Override
public void close() throws IOException {
try {
- executeCancellation();
+ cancelJob(jobListener);
+ } catch (Exception e) {
+ log.error("Exception occurred while cancelling job", e);
} finally {
try {
cleanupWorkingDirectory();
Review Comment:
While closing why the full job needs to be canceled ?
Is the `close()` only called while cancelling , also is it possible to add
something like what [MRJobLauncher
does](https://github.com/apache/gobblin/blob/master/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/mapreduce/MRJobLauncher.java#L289)
```
@Override
public void close() throws IOException {
try {
if (this.hadoopJobSubmitted && !this.job.isComplete()) {
LOG.info("Killing the Hadoop MR job for job " +
this.jobContext.getJobId());
this.job.killJob();
}
} finally {
try {
cleanUpWorkingDirectory();
} finally {
super.close();
fs.close();
}
}
}
```
Issue Time Tracking
-------------------
Worklog Id: (was: 957047)
Time Spent: 20m (was: 10m)
> Fix Temporal metrics scope closure bug
> --------------------------------------
>
> Key: GOBBLIN-2194
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2194
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-metrics
> Reporter: Abhishek Jain
> Assignee: Issac Buenrostro
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> As part of https://issues.apache.org/jira/browse/GOBBLIN-2192 a bug was
> introduced where the metrics scope object was not closed resulting in AM
> container not shutting down.
> Metrics scope should be closed wherever initialized.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
