[
https://issues.apache.org/jira/browse/GOBBLIN-2194?focusedWorklogId=957050&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-957050
]
ASF GitHub Bot logged work on GOBBLIN-2194:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Feb/25 07:30
Start Date: 14/Feb/25 07:30
Worklog Time Spent: 10m
Work Description: abhishekmjain commented on code in PR #4097:
URL: https://github.com/apache/gobblin/pull/4097#discussion_r1955674239
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/joblauncher/GobblinJobLauncher.java:
##########
@@ -137,7 +137,9 @@ public GobblinJobLauncher(Properties jobProps, Path
appWorkDir,
@Override
public void close() throws IOException {
try {
- executeCancellation();
+ cancelJob(jobListener);
+ } catch (Exception e) {
+ log.error("Exception occurred while cancelling job", e);
} finally {
try {
cleanupWorkingDirectory();
Review Comment:
Even with `executeCancellation` full job gets cancelled. `cancelJob` is just
a synchronized way to cancel - cancelJob waits on `cancellationRequest` whereas
`executeCancellation` directly calls cancel. `executeCancellation` may execute
in two threads parallelly if we don't change this.
`MRJobLauncher` is also calling `killJob` directly which is not something
which should be followed. (I believe this might have been translated to calling
`executeCancellation` directly in Temporal when the code was first written)
Issue Time Tracking
-------------------
Worklog Id: (was: 957050)
Time Spent: 0.5h (was: 20m)
> Fix Temporal metrics scope closure bug
> --------------------------------------
>
> Key: GOBBLIN-2194
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2194
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-metrics
> Reporter: Abhishek Jain
> Assignee: Issac Buenrostro
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> As part of https://issues.apache.org/jira/browse/GOBBLIN-2192 a bug was
> introduced where the metrics scope object was not closed resulting in AM
> container not shutting down.
> Metrics scope should be closed wherever initialized.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
