[
https://issues.apache.org/jira/browse/GOBBLIN-939?focusedWorklogId=336969&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-336969
]
ASF GitHub Bot logged work on GOBBLIN-939:
------------------------------------------
Author: ASF GitHub Bot
Created on: 31/Oct/19 18:06
Start Date: 31/Oct/19 18:06
Worklog Time Spent: 10m
Work Description: Will-Lo commented on pull request #2788: [GOBBLIN-939]
Integrate usage of env variables in gobblin scripts and configs
URL: https://github.com/apache/incubator-gobblin/pull/2788#discussion_r341290769
##########
File path: bin/gobblin.sh
##########
@@ -283,18 +291,18 @@ elif [[ -f ${GOBBLIN_CONF}/log4j.properties ]]; then
LOG4J_OPTS="-Dlog4j.configuration=$LOG4J_FILE_PATH"
fi
+#Create required directories
if [[ ! -d "$GOBBLIN_LOGS" ]]; then
mkdir -p $GOBBLIN_LOGS
fi
-GC_OPTS=''
-if [[ ${ENABLE_GC_LOGS} -eq 1 ]]; then
- GC_OPTS+="-XX:+UseConcMarkSweepGC -XX:+UseParNewGC -XX:+UseCompressedOops "
- GC_OPTS+="-XX:+PrintGCDetails -XX:+PrintGCDateStamps
-XX:+PrintTenuringDistribution "
- GC_OPTS+="-XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=$GOBBLIN_LOGS/ "
- GC_OPTS+="-Xloggc:$GOBBLIN_LOGS/gobblin-$GOBBLIN_MODE-gc.log "
+if [[ ! -d "$GOBBLIN_WORK_DIR" ]]; then
+ mkdir -p $GOBBLIN_WORK_DIR
fi
+if [[ ! -d "$GOBBLIN_JOB_CONFIG_DIR" ]]; then
+ mkdir -p $GOBBLIN_JOB_CONFIG_DIR
+fi
Review comment:
If these are initiated using `gobblin-env.sh`, and called in `gobblin.sh`
and never overwritten before the directories are created, would it be possible
to modify the env variables?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 336969)
> Integrate usage of env variables in gobblin scripts and configs
> ---------------------------------------------------------------
>
> Key: GOBBLIN-939
> URL: https://issues.apache.org/jira/browse/GOBBLIN-939
> Project: Apache Gobblin
> Issue Type: Improvement
> Affects Versions: 0.14.0
> Reporter: Jay Sen
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> 1. standardize config with ENV variables
> 2. define default env variables in gobblin-env.sh
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
