[ 
https://issues.apache.org/jira/browse/GOBBLIN-939?focusedWorklogId=337575&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337575
 ]

ASF GitHub Bot logged work on GOBBLIN-939:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Nov/19 21:49
            Start Date: 01/Nov/19 21:49
    Worklog Time Spent: 10m 
      Work Description: codecov-io commented on issue #2788: [GOBBLIN-939] 
Integrate usage of env variables in gobblin scripts and standardize configs
URL: 
https://github.com/apache/incubator-gobblin/pull/2788#issuecomment-548517189
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2788?src=pr&el=h1)
 Report
   > Merging 
[#2788](https://codecov.io/gh/apache/incubator-gobblin/pull/2788?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/60e3ab56a6a5bd1fd7c7c31586d6739581fe354f?src=pr&el=desc)
 will **decrease** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-gobblin/pull/2788/graphs/tree.svg?width=650&token=4MgURJ0bGc&height=150&src=pr)](https://codecov.io/gh/apache/incubator-gobblin/pull/2788?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2788      +/-   ##
   ============================================
   - Coverage     45.34%   45.32%   -0.03%     
   + Complexity     8864     8859       -5     
   ============================================
     Files          1894     1894              
     Lines         70879    70879              
     Branches       7795     7795              
   ============================================
   - Hits          32141    32126      -15     
   - Misses        35776    35788      +12     
   - Partials       2962     2965       +3
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2788?src=pr&el=tree) 
| Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2788/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh)
 | `40% <0%> (-20%)` | `2% <0%> (-1%)` | |
   | 
[.../org/apache/gobblin/async/AsyncDataDispatcher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2788/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2FzeW5jL0FzeW5jRGF0YURpc3BhdGNoZXIuamF2YQ==)
 | `79.66% <0%> (-8.48%)` | `13% <0%> (-1%)` | |
   | 
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2788/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
 | `92.85% <0%> (-7.15%)` | `3% <0%> (-1%)` | |
   | 
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2788/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
 | `35.51% <0%> (-3.74%)` | `12% <0%> (-1%)` | |
   | 
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2788/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
 | `63.42% <0%> (-1.86%)` | `27% <0%> (-1%)` | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2788?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2788?src=pr&el=footer).
 Last update 
[60e3ab5...8c7f1be](https://codecov.io/gh/apache/incubator-gobblin/pull/2788?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 337575)
    Time Spent: 1h 50m  (was: 1h 40m)

> Integrate usage of env variables in gobblin scripts and configs
> ---------------------------------------------------------------
>
>                 Key: GOBBLIN-939
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-939
>             Project: Apache Gobblin
>          Issue Type: Improvement
>    Affects Versions: 0.14.0
>            Reporter: Jay Sen
>            Priority: Major
>             Fix For: 0.15.0
>
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> 1. standardize config with ENV variables 
> 2. define default env variables in gobblin-env.sh



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to