[
https://issues.apache.org/jira/browse/GOBBLIN-939?focusedWorklogId=337068&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337068
]
ASF GitHub Bot logged work on GOBBLIN-939:
------------------------------------------
Author: ASF GitHub Bot
Created on: 31/Oct/19 21:42
Start Date: 31/Oct/19 21:42
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2788: [GOBBLIN-939]
Integrate usage of env variables in gobblin scripts and configs
URL:
https://github.com/apache/incubator-gobblin/pull/2788#issuecomment-548517189
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2788?src=pr&el=h1)
Report
> Merging
[#2788](https://codecov.io/gh/apache/incubator-gobblin/pull/2788?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/9ee4dcaf66257b6e2926cf1470b16b912cd343ff?src=pr&el=desc)
will **increase** coverage by `41.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2788?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2788 +/- ##
=============================================
+ Coverage 4.15% 45.33% +41.18%
- Complexity 746 8863 +8117
=============================================
Files 1894 1894
Lines 70877 70879 +2
Branches 7793 7795 +2
=============================================
+ Hits 2946 32136 +29190
+ Misses 67617 35781 -31836
- Partials 314 2962 +2648
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2788?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...gobblin/service/monitoring/JobStatusRetriever.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2788/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9Kb2JTdGF0dXNSZXRyaWV2ZXIuamF2YQ==)
| `0% <0%> (ø)` | `2% <0%> (+2%)` | :arrow_up: |
|
[...ata/management/copy/hive/HivePartitionFileSet.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2788/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaGl2ZS9IaXZlUGFydGl0aW9uRmlsZVNldC5qYXZh)
| `0.95% <0%> (+0.95%)` | `1% <0%> (+1%)` | :arrow_up: |
|
[...ain/java/org/apache/gobblin/runtime/TaskState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2788/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFza1N0YXRlLmphdmE=)
| `81.97% <0%> (+1.16%)` | `32% <0%> (ø)` | :arrow_down: |
|
[...pache/gobblin/runtime/GobblinMultiTaskAttempt.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2788/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvR29iYmxpbk11bHRpVGFza0F0dGVtcHQuamF2YQ==)
| `56.3% <0%> (+1.35%)` | `27% <0%> (+2%)` | :arrow_up: |
|
[...ava/org/apache/gobblin/runtime/MultiConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2788/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvTXVsdGlDb252ZXJ0ZXIuamF2YQ==)
| `83.6% <0%> (+1.63%)` | `9% <0%> (+1%)` | :arrow_up: |
|
[...rg/apache/gobblin/runtime/FsDatasetStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2788/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvRnNEYXRhc2V0U3RhdGVTdG9yZS5qYXZh)
| `73.8% <0%> (+1.78%)` | `35% <0%> (+1%)` | :arrow_up: |
|
[...a/org/apache/gobblin/cluster/SingleTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2788/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvU2luZ2xlVGFza1J1bm5lci5qYXZh)
| `1.85% <0%> (+1.85%)` | `1% <0%> (+1%)` | :arrow_up: |
|
[.../java/org/apache/gobblin/runtime/TaskExecutor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2788/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFza0V4ZWN1dG9yLmphdmE=)
| `45.05% <0%> (+2.19%)` | `9% <0%> (+1%)` | :arrow_up: |
|
[...apache/gobblin/source/jdbc/SqlServerExtractor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2788/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9qZGJjL1NxbFNlcnZlckV4dHJhY3Rvci5qYXZh)
| `4.41% <0%> (+4.41%)` | `3% <0%> (+3%)` | :arrow_up: |
|
[...rg/apache/gobblin/runtime/AbstractJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2788/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvQWJzdHJhY3RKb2JMYXVuY2hlci5qYXZh)
| `59.13% <0%> (+5.1%)` | `33% <0%> (+6%)` | :arrow_up: |
| ... and [1087
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2788/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2788?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2788?src=pr&el=footer).
Last update
[9ee4dca...893e060](https://codecov.io/gh/apache/incubator-gobblin/pull/2788?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 337068)
Time Spent: 1h 20m (was: 1h 10m)
> Integrate usage of env variables in gobblin scripts and configs
> ---------------------------------------------------------------
>
> Key: GOBBLIN-939
> URL: https://issues.apache.org/jira/browse/GOBBLIN-939
> Project: Apache Gobblin
> Issue Type: Improvement
> Affects Versions: 0.14.0
> Reporter: Jay Sen
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> 1. standardize config with ENV variables
> 2. define default env variables in gobblin-env.sh
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
