[
https://issues.apache.org/jira/browse/GOBBLIN-939?focusedWorklogId=336968&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-336968
]
ASF GitHub Bot logged work on GOBBLIN-939:
------------------------------------------
Author: ASF GitHub Bot
Created on: 31/Oct/19 18:06
Start Date: 31/Oct/19 18:06
Worklog Time Spent: 10m
Work Description: Will-Lo commented on pull request #2788: [GOBBLIN-939]
Integrate usage of env variables in gobblin scripts and configs
URL: https://github.com/apache/incubator-gobblin/pull/2788#discussion_r341287822
##########
File path: bin/gobblin-env.sh
##########
@@ -17,4 +17,6 @@
# limitations under the License.
#
-# Set Gobblin specific environment variables here.
+# export environment variables here to be used in gobblin.sh scripts and
gobblin platform configs.
+export GOBBLIN_WORK_DIR=$GOBBLIN_HOME/gobblin-work-dir
+export GOBBLIN_JOB_CONFIG_DIR=$GOBBLIN_HOME/gobblin-job-config-dir
Review comment:
I think to keep it more consistent with our old naming conventions we should
do
`GOBBLIN_WORK_DIR=$GOBBLIN_HOME/work`
`GOBBLIN_JOB_CONFIG_DIR=$GOBBLIN_HOME/jobs`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 336968)
Time Spent: 20m (was: 10m)
> Integrate usage of env variables in gobblin scripts and configs
> ---------------------------------------------------------------
>
> Key: GOBBLIN-939
> URL: https://issues.apache.org/jira/browse/GOBBLIN-939
> Project: Apache Gobblin
> Issue Type: Improvement
> Affects Versions: 0.14.0
> Reporter: Jay Sen
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> 1. standardize config with ENV variables
> 2. define default env variables in gobblin-env.sh
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
