+1 (non-binding)

List of items have been checked.

1. normal check with hbase-vote.sh
        * Signature: ok
        * Checksum : ok
        * Rat check (1.8.0_282): ok
         - mvn clean apache-rat:check
        * Built from source (1.8.0_282): ok
         - mvn clean install -DskipTests
        * Unit tests pass (1.8.0_282): ok
         - mvn package -P runAllTests

2. Release note mostly looks good, few minor comment /
  - [nit] format of HBASE-27055 with HBASE_OPTS seems off.
  - [nit] why does the history of release notes does not
           have section for 2.3.0 and 2.4.0?

3. verified hbase CLI tests, create/put/get/scan/flush/list/disable/drop, ok
4. verified with LTT test, ok
 - bin/hbase ltt -num_keys 1000000 -write 10:1000:32


[discuss] we can take it out of this thread, but how long
does it take to execute tests with -P runAllTests ?

it took 16:35 hours to have the unit tests completely executed inside docker
runner with 4 CPUs and 10GB....I'm wondered how i could have it run faster.

-Stephen


On Fri, Aug 26, 2022 at 8:27 AM 张铎(Duo Zhang) <palomino...@gmail.com> wrote:
>
> Filed HBASE-27335 and HBASE-27336.
>
> Nick Dimiduk <ndimi...@apache.org> 于2022年8月26日周五 02:10写道:
> >
> > Thanks for checking it out Duo. Please file tickets for both of those
> > issues (if you have not done so yet).
> >
> > -n
> >
> > On Thu, Aug 25, 2022 at 14:43 张铎(Duo Zhang) <palomino...@gmail.com> wrote:
> >
> > > +1 binding
> > >
> > > Checked sigs and sums: Matched
> > > Rat check: Passed
> > > Built from src: Passed with AdoptOpenJDK-11.0.11+9
> > > Run UTs: Some UTs in hbase-server module failed at the first time and
> > > passed while running the UTs in hbase-server module separately again,
> > > with AdoptOpenJDK-11.0.11+9 and hadoop.profile=3.0
> > > Start a mini cluster: OK with the downloaded binary, the status page
> > > looks almost fine(see issues below)
> > > Run basic (shell) commands: OK with the downloaded client binary.
> > > Loaded 10000 rows with LTT, ran 'count' command on the table in shell,
> > > returned 10000 rows. Flush command is also fine, and will make the
> > > region visualizer to show something
> > >
> > > Issues:
> > > The region visualizer is interesting, it could show the total region
> > > size, but the region server info just shows as 'undefined'.
> > > When quiting the hbase shell, the command will hang several tens of
> > > seconds before shutting down. Not a blocker as it could finally quit,
> > > but still a bit annoying.
> > >
> > > Thanks Nick!
> > >
> > > Nick Dimiduk <ndimi...@apache.org> 于2022年8月24日周三 17:53写道:
> > > >
> > > > Please vote on this Apache hbase release candidate,
> > > > hbase-2.5.0RC1
> > > >
> > > > The VOTE will remain open for at least 72 hours.
> > > >
> > > > [ ] +1 Release this package as Apache hbase 2.5.0
> > > > [ ] -1 Do not release this package because ...
> > > >
> > > > The tag to be voted on is 2.5.0RC1:
> > > >
> > > >   https://github.com/apache/hbase/tree/2.5.0RC1
> > > >
> > > > This tag currently points to git reference
> > > >
> > > >   2ecd8bd6d615ca49bfb329b3c0c126c80846d4ab
> > > >
> > > > The release files, including signatures, digests, as well as CHANGES.md
> > > > and RELEASENOTES.md included in this RC can be found at:
> > > >
> > > >   https://dist.apache.org/repos/dist/dev/hbase/2.5.0RC1/
> > > >
> > > > Maven artifacts are available in a staging repository at:
> > > >
> > > >
> > > https://repository.apache.org/content/repositories/orgapachehbase-1494/
> > > >
> > > > Artifacts were signed with the 0x18567F39 key which can be found in:
> > > >
> > > >   https://downloads.apache.org/hbase/KEYS
> > > >
> > > > To learn more about Apache hbase, please see
> > > >
> > > >   http://hbase.apache.org/
> > > >
> > > > Thanks,
> > > > Your HBase Release Manager
> > >

Reply via email to