[
https://issues.apache.org/jira/browse/HTTPCORE-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570431#action_12570431
]
Oleg Kalnichevski commented on HTTPCORE-148:
--------------------------------------------
Hi Sam
I and Roland get frequently locked in all sorts of API disputes. Usually
emotions run high and we both stop just short of calling a preemptive nuclear
strike onto one another. A way out of such situation that seems to work
reasonably well for us is to split a major change into a series of smaller
patches and find a compromise on one thing at a time. So far, I have to say
results have been quite encouraging. So, I went ahead stripped your patch of
all features that I deemed non-essential (secondary) and committed the rest to
a separate branch in SVN
http://svn.apache.org/repos/asf/httpcomponents/httpcore/branches/limewire_contrib/
I cleaned up certain areas but generally left most of the things intact. Tests
pass for me. The example code seems to work. Generally things are looking up.
Now I would like to try to make more radical changes and see if you could live
with them. Feel free to review the code I checked in and let me know if you
find anything disagreeable. I'll submit my proposal either as a patch against
the new branch or commit them directly if that is okay with you.
I removed the commit trigger stuff for the time being in order to keep things
simpler. Besides, we'll have to ensure the commit trigger is threading safe so
that the response commit could be triggered from a worker thread.
Oleg
Oleg
> Create AsyncNHttpServiceHandler & AsyncNHttpClientHandler
> ---------------------------------------------------------
>
> Key: HTTPCORE-148
> URL: https://issues.apache.org/jira/browse/HTTPCORE-148
> Project: HttpComponents Core
> Issue Type: New Feature
> Components: HttpCore NIO
> Affects Versions: 4.0-beta2
> Reporter: Sam Berlin
> Assignee: Oleg Kalnichevski
> Attachments: changes.txt, changes2.txt
>
>
> Attached is a patch for AsyncNHttpServiceHandler. It actually works (as
> tested by running & hitting it with IE.) :)
> To test, run the example 'AsyncNHttpFileServer' in the examples directory or
> the TestAsyncNHttpHandlers test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
