[
https://issues.apache.org/jira/browse/HTTPCORE-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571192#action_12571192
]
Oleg Kalnichevski commented on HTTPCORE-148:
--------------------------------------------
Sam,
I committed all changes but the NHttpResponseTrigger code. I feel
NHttpResponseTrigger implementation must be threading safe. Inevitably there
are going to be cases where a processing thread is employed to execute some
potentially blocking logic in order to generate and commit a response.
AsyncNHttpServiceHandler needs to be prepared to handle cases like that. So, in
order words NHttpResponseTrigger cannot submit the response object to the
underlying connection directly. It has to update the connection state object
and then trigger #responseReady even, which in its turn can safely submit the
response on the I/O dispatch thread.
At the moment I would like to minimize the extent of changes to HttpCore. We
will have significantly more freedom in HttpClient. So, I would prefer
stubbed-out methods for "responseSent' and 'requestReceived' events.
Let's keep this code on the branch for the time being until we are more or less
happy with the client side of things.
Many thanks for this contribution and for putting up with my grumbling
Oleg
> Create AsyncNHttpServiceHandler & AsyncNHttpClientHandler
> ---------------------------------------------------------
>
> Key: HTTPCORE-148
> URL: https://issues.apache.org/jira/browse/HTTPCORE-148
> Project: HttpComponents HttpCore
> Issue Type: New Feature
> Components: HttpCore NIO
> Affects Versions: 4.0-beta1
> Reporter: Sam Berlin
> Assignee: Oleg Kalnichevski
> Fix For: 4.0-beta2
>
> Attachments: changes.txt, changes.txt, changes2.txt
>
>
> Attached is a patch for AsyncNHttpServiceHandler. It actually works (as
> tested by running & hitting it with IE.) :)
> To test, run the example 'AsyncNHttpFileServer' in the examples directory or
> the TestAsyncNHttpHandlers test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
