[
https://issues.apache.org/jira/browse/HTTPCORE-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570511#action_12570511
]
Sam Berlin commented on HTTPCORE-148:
-------------------------------------
Excellent suggestion. Working on the branch should also make reviewing
incremental changes much easier.
Feel free to experiment at will (either directly or in the form of patches) --
I'm going to play around with it too (first to update javadocs & add some small
missing changes, such as the UriPatternMatcher as the basis for an
NHttpRequestHandlerRegistry & HttpRequestHandlerRegistry).
I'm still searching for a good way to support delegating to blocking handlers.
Returning true|false after consuming content is just too ugly for my liking.
Perhaps there should be an additional method in NHttpRequestHandler:
shouldHandleAfterRequestConsumed(...). The issue I see with that is that in
almost every case, the answer is 'true'. It's only in the blocking case where
it should return 'false'. Maybe there should be a marker interface that these
kinds of handlers implement? ... I dunno.
> Create AsyncNHttpServiceHandler & AsyncNHttpClientHandler
> ---------------------------------------------------------
>
> Key: HTTPCORE-148
> URL: https://issues.apache.org/jira/browse/HTTPCORE-148
> Project: HttpComponents Core
> Issue Type: New Feature
> Components: HttpCore NIO
> Affects Versions: 4.0-beta1
> Reporter: Sam Berlin
> Assignee: Oleg Kalnichevski
> Fix For: 4.0-beta2
>
> Attachments: changes.txt, changes2.txt
>
>
> Attached is a patch for AsyncNHttpServiceHandler. It actually works (as
> tested by running & hitting it with IE.) :)
> To test, run the example 'AsyncNHttpFileServer' in the examples directory or
> the TestAsyncNHttpHandlers test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
