On Wed, May 10, 2017 at 10:13 AM, Oleg Kalnichevski <ol...@apache.org> wrote:
> ... > > > > > One personal request. Do you think you could try to make your > > > commits > > > less granular and combine logically related changes into larger > > > change > > > sets? > > > > > > > Old habits die hard. Git might indeed make this better. If you want > > to add > > this to the style guideline on the site, it will help all > > contributors, > > present and future. > > > > Hi Gary > > I do not think it would be possible to enforce it through a style check > or a commit hook as there are legitimate reasons for one line commits. > > Please do not get me wrong. I have no intentions of changing your way > of working. I fully respect other people's habits. What I am asking is > your consent to squash some of your commits (combining small related > commit into a larger one). > Oh sure, feel free to do what you want. I did read something a long time ago warning git users about fiddling with repo history, but since we have a master repo and we are not truly using git in a distributed way, that should not hurt us. Gary > > Oleg > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org > For additional commands, e-mail: dev-h...@hc.apache.org > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459> JUnit in Action, Second Edition <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021> Spring Batch in Action <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
