tippl commented on PR #555: URL: https://github.com/apache/httpcomponents-client/pull/555#issuecomment-2002499629
> @tippl I apologize if I have said was misleading but the idea was to provide hooks for performance metrics without exposing the whole thing in the public APIs. > > 1. Please add those callback methods as protected empty methods to the `DefaultHttpClientConnectionOperator`. One would need to subclass `DefaultHttpClientConnectionOperator` and override relevant methods in order to add custom logic > 2. Symmetric changes need to be made `DefaultHttpClientConnectionOperator`. We must keep the classic and the async client implementation consistent. @ok2c Okay, i do have a few things then: 1. While keeping the `PoolingHttpClientConnectionManager` constructor internal, should I add a way to provide a custom `HttpClientConnectionOperator` to the `PoolingHttpClientConnectionManager`? 2. The `DefaultAsyncClientConnectionOperator` is final, i'll open it up to extending. 3. There is no "easy" way at least from first look to hook around DNS resolution in the `DefaultAsyncClientConnectionOperator`, since that is inside of the `MultihomeIOSessionRequester`. But you can work around that by implementing your own `DnsResolver` and have that handle metrics, so I'll remove the callbacks for DNS. If you're okay with these, I'll work on implementing the changes. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
